unify queries #11
Merged
unify queries #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the agent connection implementation by introducing a unified query interface (query_unified) that consolidates functionality from multiple deprecated methods. The refactoring aims to reduce code duplication by having all query methods delegate to a single implementation.
- Introduces new
QueryResultdataclass andquery_unifiedmethod as the central query interface - Deprecates
query_with_tools,query_with_tracking,query_with_schema, andquery_with_schema_and_trackingmethods, replacing their implementations with calls toquery_unified - Updates mypy configuration to type-check tests and adds error suppression for test-specific issues
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/cellsem_llm_client/agents/agent_connection.py | Adds unified query interface with QueryResult dataclass and query_unified method; refactors existing methods to use the new interface; extracts helper methods _run_tool_loop and _build_usage_metrics |
| tests/unit/test_agent_connection.py | Adds unit tests for new query_unified method and deprecation warnings; updates existing test with proper tool definition |
| pyproject.toml | Updates author email, changes development status classifier, and adds mypy error suppression for tests |
| .pre-commit-config.yaml | Updates mypy pre-commit hook to use config file and check both src and tests |
| .github/workflows/test.yml | Adds tests directory to mypy checks in CI workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Contributor
Co-authored-by: Copilot <[email protected]>
Co-authored-by: dosumis <[email protected]>
Co-authored-by: dosumis <[email protected]>
Accumulate usage metrics across tool call iterations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.